feat: Added control to create logs by Lambda@Edge in all regions #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
requested changes
May 16, 2023
variables.tf
Outdated
| @@ -50,6 +50,12 @@ variable "lambda_at_edge" { | |||
| default = false | |||
| } | |||
|
|
|||
| variable "create_lambda_at_edge_all_regions_access_policy" { | |||
| description = "Set this to false if you do not want to create Lambda@Edge logs in all regions" | |||
There was a problem hiding this comment.
Suggested change
| description = "Set this to false if you do not want to create Lambda@Edge logs in all regions" | |
| description = "Whether to specify a wildcard in IAM policy used by Lambda@Edge to allow logging in all regions" |
examples/complete/main.tf
Outdated
| @@ -262,6 +262,7 @@ module "lambda_at_edge" { | |||
| source = "../../" | |||
|
|
|||
| lambda_at_edge = true | |||
| create_lambda_at_edge_all_regions_access_policy = false | |||
There was a problem hiding this comment.
Suggested change
| create_lambda_at_edge_all_regions_access_policy = false |
antonbabenko
changed the title
rysi3k
force-pushed
the
do_not_allow_to_create_logs_in_all_regions
branch
from
6b66eb9 to
bcff87b
Compare
|
@antonbabenko changed according to your suggestions |
antonbabenko
pushed a commit
that referenced
this pull request
May 17, 2023
## [4.18.0](v4.17.0...v4.18.0) (2023-05-17) ### Features * Added control to create logs by Lambda@Edge in all regions ([#462](#462)) ([712d8ec](712d8ec))
|
This PR is included in version 4.18.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added simple flag, for not create IAM policy which allows to create logs by Lambda@Edge in regions other than N.Virginia.
Motivation and Context
In some cases that logs are not necessary, but storing it costs extra $.
Breaking Changes
NO
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request